fix: use correct env var to detect gitlab CI for OIDC #6938
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemyan
approved these changes
Oct 12, 2025
Gudahtt
added a commit
to Gudahtt/berry
that referenced
this pull request
Feb 9, 2026
…lowlist * origin/master: (212 commits) CI: Select node version to run CI against automatically (yarnpkg#7032) Fixes foreach order when --topological isnt set (yarnpkg#6997) fix(fslib): handle float timestamps in convertToBigIntStats (yarnpkg#6988) Fixes the `/<name>/<version>` format (yarnpkg#6993) docs(constraints): add missing @typedef alias for `Context` (yarnpkg#6989) Sync master with the changes from master Releasing 3 new packages Fix JSON Schema (yarnpkg#6973) Implements npm web login support (yarnpkg#6981) fix(git): split `-c` and `core.autocrlf=false` into separate args for `clone` (yarnpkg#6983) Sync master with the changes from master Releasing 8 new packages Allow catalogs to work with descriptors without resolvers (yarnpkg#6930) docs: Clarify additional use-case of npmMinimalAgeGate (yarnpkg#6945) Migrates the "typescript" dependencies to a catalog (yarnpkg#6969) Support escaping template variables in environment values (yarnpkg#6935) Core: Create DURATION settings type (yarnpkg#6942) fix: use correct env var to detect gitlab CI for OIDC (yarnpkg#6938) Update README.md badge link (yarnpkg#6947) fix(publish): use correct workspace name in --json output (yarnpkg#6949) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
When #6898 added support for OIDC publishing, it copied the getOidcToken function from npm's implementation. However,
ciInfowas directly replaced withprocess.env, which coincidentally worked fine for GitHub Actions (both theciInfoconstant and the environment variable are namedGITHUB_ACTIONS), but not for GitLab (theciInfoconstant isGITLAB, but the actual env var isGITLAB_CI).How did you fix it?
Replaced
process.env.GITLABwithprocess.env.GITLAB_CIChecklist